OAuth Manager and OAuth2/OpenID connect Plugin#156
Closed
markus-96 wants to merge 11 commits intopikvm:oauth-prototypefrom
Closed
OAuth Manager and OAuth2/OpenID connect Plugin#156markus-96 wants to merge 11 commits intopikvm:oauth-prototypefrom
markus-96 wants to merge 11 commits intopikvm:oauth-prototypefrom
Conversation
still having three errors with mypy: kvmd\plugins\auth\oauth2.py:142: error: Function is missing a return type annotation [no-untyped-def] kvmd\apps\kvmd\oauth.py:102: error: Function is missing a return type annotation [no-untyped-def] kvmd\apps\kvmd\oauth.py:117: error: Function is missing a return type annotation [no-untyped-def]
Member
|
Jfyi I don't forget about it, just very busy with other tasks. |
Author
If you were notified by my merges of upstream, sry for that. Had to do the merges because otherwise I was not able to get it running on actual hardware. Take your time, I only was in a hurry when writing the code and getting it on the pi. |
Member
|
I'm lazy working on it. |
Member
|
Moved to #194 with bunch of fixes. |
mdevaev
pushed a commit
that referenced
this pull request
Sep 6, 2025
intelfx
pushed a commit
to intelfx/kvmd
that referenced
this pull request
Nov 14, 2025
intelfx
pushed a commit
to intelfx/kvmd
that referenced
this pull request
Nov 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added the possibility to define OAuth Providers as authentication backend.
/etc/kvmd/auth.yamlhas to look like the following:It will define two Providers. Both are identified by the key for their config dict, so we have two:
keycloakandgithubThe first one, GitHub, is accessable withhttps://<PiKVM>/api/auth/oauth/login/github, the second one, Keycloak, withhttps://<PiKVM>/api/auth/oauth/login/keycloak. The callback urls arehttps://<PiKVM>/api/auth/oauth/callback/<provider-key>.The oauth2 plugin implements the authorization code flow.